Removed setting the flatfield on zoom level changes #803
+1
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
requested review from
rtuck99,
noemifrisina,
dperl-dls and
olliesilvester
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
- Coverage 95.01% 95.00% -0.01%
==========================================
Files 116 116
Lines 4753 4744 -9
==========================================
- Hits 4516 4507 -9
Misses 237 237 ☔ View full report in Codecov by Sentry. |
noemifrisina
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
lgtm, thanks.
There seems to be a test in mx-bluesky using this:
https://github.com/DiamondLightSource/mx-bluesky/blob/41d55a417b4c272dccf64571d7c6a5e0621d895e/tests/unit_tests/hyperion/device_setup_plans/test_setup_oav.py#L31
Please make sure it's also removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #801
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}